Workflow Dispatch Command Injection Fix #24864
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: build
There was a problem hiding this comment.
Pull Request Overview
This PR mitigates potential command injection vulnerabilities by changing the way GitHub context inputs are passed into commands.
- Uses environment variables to safely supply the input values instead of inline interpolation.
- Refactors both the PR number and tag input retrieval in the workflow files.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/release-approval.yml | Refactored PR input handling using an env block to safely reference the input in the echo step. |
| .github/workflows/push-tag-create-release.yml | Refactored tag input handling via env blocks in multiple steps to avoid direct interpolation. |
Abe27342
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix sets GitHub context variables (github.event.inputs.*) as env directives instead of directly sticking them into a command. Doing this ensures that potential shell characters are properly escaped, mitigating the risk of command injection attacks.